Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(template-parser): correct typings for cjs #597

Merged
merged 2 commits into from
Jul 15, 2021
Merged

fix(template-parser): correct typings for cjs #597

merged 2 commits into from
Jul 15, 2021

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Jul 15, 2021

No description provided.

@nx-cloud
Copy link

nx-cloud bot commented Jul 15, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit 89f1343. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=check-configs --all --parallel
#000000 nx run-many --target=integration-test --all --withRegistry
#000000 nx run-many --target=test --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@JounQin JounQin changed the title fix: correct typings for template parser fix(template-parser): correct typings for cjs Jul 15, 2021
JamesHenry
JamesHenry approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JounQin

@JamesHenry JamesHenry merged commit bb60224 into angular-eslint:master Jul 15, 2021
@JounQin JounQin deleted the fix/template-parser branch July 15, 2021 13:48
rafaelss95 pushed a commit to rafaelss95/angular-eslint that referenced this pull request Jul 23, 2021
@JounQin @rafaelss95
fix(template-parser): correct typings for cjs (angular-eslint#597)
daa28f6
rafaelss95 pushed a commit to rafaelss95/angular-eslint that referenced this pull request Jul 23, 2021
@JounQin @rafaelss95
fix(template-parser): correct typings for cjs (angular-eslint#597)
328968c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JounQin @JamesHenry