Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin-template): [no-negated-async] values used with the… #1606

Conversation

abaran30
Copy link
Contributor

@abaran30 abaran30 commented Nov 9, 2023

… async pipe are not negated

Fixes #1566

Copy link

nx-cloud bot commented Nov 9, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9ca0ad0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #1606 (9ca0ad0) into main (4eddce1) will increase coverage by 0.02%.
Report is 7 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1606      +/-   ##
==========================================
+ Coverage   89.56%   89.58%   +0.02%     
==========================================
  Files         167      167              
  Lines        3133     3141       +8     
  Branches      530      531       +1     
==========================================
+ Hits         2806     2814       +8     
  Misses        195      195              
  Partials      132      132              
Flag Coverage Δ
unittest 89.58% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...lint-plugin-template/src/rules/no-negated-async.ts 100.00% <100.00%> (ø)
...gin-template/tests/rules/no-negated-async/cases.ts 100.00% <100.00%> (ø)
packages/template-parser/src/index.ts 89.13% <ø> (ø)

@JamesHenry JamesHenry merged commit 24a4ed9 into angular-eslint:main Nov 15, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants