Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update dependency prettier to v3.3.2 #1694

Merged
merged 2 commits into from
Jul 1, 2024
Merged

chore: update dependency prettier to v3.3.2 #1694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afe8adf
chore: update dependency prettier to v3.3.2
renovate[bot] Jun 30, 2024
239afaa
chore: update formatting and jsonc ignores
JamesHenry Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/CONFIGURING_ESLINTRC.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ Let's take a look at full (but minimal), manual example of a config file (**alth

**.eslintrc.json**

<!-- prettier-ignore -->
```jsonc
{
"root": true,
Expand Down Expand Up @@ -145,6 +146,7 @@ Our premade configs handle the `parser` and `plugins` options for you behind the

If for some reason you wanted to not include any of the premade recommended configs, or you wanted to significantly customize your setup, a fully manual example with the right parsers and plugins wired up (but no actual rules activated) would look like this:

<!-- prettier-ignore -->
```jsonc
{
"root": true,
Expand Down Expand Up @@ -195,6 +197,7 @@ If you choose to use `eslint-plugin-prettier`, **please ensure that you are usin

**.eslintrc.json**

<!-- prettier-ignore -->
```jsonc
{
"root": true,
Expand Down
4 changes: 2 additions & 2 deletions docs/MIGRATING_FROM_TSLINT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ If you would like to recreate the `ng-cli-compat` and `ng-cli-compat--formatting

**ng-cli-compat**

```jsonc
```json
{
"parser": "@typescript-eslint/parser",
"plugins": ["@typescript-eslint", "@angular-eslint"],
Expand Down Expand Up @@ -431,7 +431,7 @@ If you would like to recreate the `ng-cli-compat` and `ng-cli-compat--formatting

**ng-cli-compat--formatting-add-on**

```jsonc
```json
{
"plugins": ["eslint-plugin-jsdoc"],
"rules": {
Expand Down
11 changes: 9 additions & 2 deletions docs/RULES_REQUIRING_TYPE_INFORMATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ By default, angular-eslint sets up your ESLint configs with performance in mind

Let's take an example of an ESLint config that angular-eslint might generate for you out of the box (in v15 onwards) for single app workspace/the root project in a multi-project workspace:

```jsonc {% fileName=".eslintrc.json" %}
```json {% fileName=".eslintrc.json" %}
{
"root": true,
"ignorePatterns": ["projects/**/*"],
Expand Down Expand Up @@ -57,6 +57,7 @@ Here we do _not_ have `parserOptions.project`, which is appropriate because we a

If we now come in and add a rule which does require type information, for example `@typescript-eslint/await-thenable`, our config will look as follows:

<!-- prettier-ignore -->
```jsonc {% fileName=".eslintrc.json" %}
{
"root": true,
Expand Down Expand Up @@ -116,6 +117,7 @@ Linting...

The solution is to update our config once more, this time to set `parserOptions.project` to appropriately point at our various tsconfig.json files which belong to our project:

<!-- prettier-ignore -->
```jsonc {% fileName=".eslintrc.json" %}
{
"root": true,
Expand Down Expand Up @@ -169,7 +171,7 @@ And that's it! Now any rules requiring type information will run correctly when

Let's take an example of an ESLint config that angular-eslint might generate for you out of the box (in v15 onwards) for a library project called `my-library`:

```jsonc {% fileName="projects/my-library/.eslintrc.json" %}
```json {% fileName="projects/my-library/.eslintrc.json" %}
{
"extends": "../../.eslintrc.json",
"ignorePatterns": ["!**/*"],
Expand Down Expand Up @@ -207,6 +209,7 @@ Here we do _not_ have `parserOptions.project`, which is appropriate because we a

If we now come in and add a rule which does require type information, for example `@typescript-eslint/await-thenable`, our config will look as follows:

<!-- prettier-ignore -->
```jsonc {% fileName="projects/my-library/.eslintrc.json" %}
{
"extends": "../../.eslintrc.json",
Expand Down Expand Up @@ -259,6 +262,7 @@ Linting "my-library"...

The solution is to update our config once more, this time to set `parserOptions.project` to appropriately point at our various tsconfig.json files which belong to our project:

<!-- prettier-ignore -->
```jsonc {% fileName="projects/my-library/.eslintrc.json" %}
{
"extends": "../../.eslintrc.json",
Expand Down Expand Up @@ -315,6 +319,7 @@ ng g @angular-eslint/schematics:library {PROJECT_NAME_HERE} --set-parser-options

If you don't want to have to remember to pass `--set-parser-options-project` each time, then you can set it to true by default in your schematic defaults in your `angular.json` file:

<!-- prettier-ignore -->
```jsonc
{
// ... more angular.json config here ...
Expand All @@ -338,6 +343,7 @@ The first thing is to understand that if you are majorly deviating from the conf

If `parserOptions.project` has been configured, by default `typescript-eslint` will take this as a sign that you only want to lint files that are captured within the scope of the TypeScript `Program`s which are created. For example, let's say you have a `tsconfig.json` that contains the following:

<!-- prettier-ignore -->
```jsonc
{
// ...more config
Expand Down Expand Up @@ -396,6 +402,7 @@ For example, it may look like:

**tsconfig.eslint.json**

<!-- prettier-ignore -->
```jsonc
{
"extends": "./tsconfig.json",
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"@types/eslint-scope": "3.7.7",
"@types/jest": "29.4.4",
"@types/node": "20.14.9",
"@types/prettier": "2.7.3",
"@types/prettier": "3.0.0",
"@types/semver": "^7.5.8",
"@typescript-eslint/rule-tester": "8.0.0-alpha.37",
"commitizen": "4.3.0",
Expand All @@ -93,7 +93,7 @@
"ncp": "2.0.0",
"nx": "19.3.2",
"patch-package": "^8.0.0",
"prettier": "3.1.1",
"prettier": "3.3.2",
"prettier-v2-for-jest-inline-snapshots": "npm:prettier@^2",
"rimraf": "5.0.7",
"rollup": "^4.0.0",
Expand Down
15 changes: 7 additions & 8 deletions packages/eslint-plugin-template/src/utils/is-semantic-role-element.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,13 @@ export function isSemanticRoleElement(
),
) &&
// aria- properties are covered by the element's semantic role
axElements?.get(htmlElement)?.find(
(roleName: string) =>
// AXObjectRoles: AXObjects are mapped to their related ARIA concepts
axRoles
?.get(roleName)
?.find(
(semanticRole: { name: string }) => semanticRole.name === role,
),
axElements?.get(htmlElement)?.find((roleName: string) =>
// AXObjectRoles: AXObjects are mapped to their related ARIA concepts
axRoles
?.get(roleName)
?.find(
(semanticRole: { name: string }) => semanticRole.name === role,
),
),
);
}
18 changes: 10 additions & 8 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2818,10 +2818,12 @@
resolved "https://registry.yarnpkg.com/@types/parse-json/-/parse-json-4.0.2.tgz#5950e50960793055845e956c427fc2b0d70c5239"
integrity sha512-dISoDXWWQwUquiKsyZ4Ng+HX2KsPL7LyHKHQwgGFEA3IaKac4Obd+h2a/a6waisAoepJlBcx9paWqjA8/HVjCw==

"@types/prettier@2.7.3":
version "2.7.3"
resolved "https://registry.yarnpkg.com/@types/prettier/-/prettier-2.7.3.tgz#3e51a17e291d01d17d3fc61422015a933af7a08f"
integrity sha512-+68kP9yzs4LMp7VNh8gdzMSPZFL44MLGqiHWvttYJe+6qnuVr4Ek9wSBQoveqY/r+LwjCcU29kNVkidwim+kYA==
"@types/prettier@3.0.0":
version "3.0.0"
resolved "https://registry.yarnpkg.com/@types/prettier/-/prettier-3.0.0.tgz#e9bc8160230d3a461dab5c5b41cceef1ef723057"
integrity sha512-mFMBfMOz8QxhYVbuINtswBp9VL2b4Y0QqYHwqLz3YbgtfAcat2Dl6Y1o4e22S/OVE6Ebl9m7wWiMT2lSbAs1wA==
dependencies:
prettier "*"

"@types/resolve@1.20.2":
version "1.20.2"
Expand Down Expand Up @@ -8151,10 +8153,10 @@ prelude-ls@^1.2.1:
resolved "https://registry.yarnpkg.com/prettier/-/prettier-2.8.8.tgz#e8c5d7e98a4305ffe3de2e1fc4aca1a71c28b1da"
integrity sha512-tdN8qQGvNjw4CHbY+XXk0JgCXn9QiF21a55rBe5LJAU+kDyC4WQn4+awm2Xfk2lQMk5fKup9XgzTZtGkjBdP9Q==

prettier@3.1.1:
version "3.1.1"
resolved "https://registry.yarnpkg.com/prettier/-/prettier-3.1.1.tgz#6ba9f23165d690b6cbdaa88cb0807278f7019848"
integrity sha512-22UbSzg8luF4UuZtzgiUOfcGM8s4tjBv6dJRT7j275NXsy2jb4aJa4NNveul5x4eqlF1wuhuR2RElK71RvmVaw==
prettier@*, prettier@3.3.2:
version "3.3.2"
resolved "https://registry.yarnpkg.com/prettier/-/prettier-3.3.2.tgz#03ff86dc7c835f2d2559ee76876a3914cec4a90a"
integrity sha512-rAVeHYMcv8ATV5d508CFdn+8/pHPpXeIid1DdrPwXnaAdH7cqjVbpJaT5eq4yRAFU/lsbwYwSF/n5iNrdJHPQA==

prettier@^3.2.5:
version "3.2.5"
Expand Down