fix(css): Add all style files to inject:css #1747
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -294,7 +294,7 @@ gulp.task('tsd:test', cb => { | |||
| });<% } %> | |||
|
|
|||
| gulp.task('styles', () => { | |||
| return gulp.src(paths.client.mainStyle) | |||
| return gulp.src(paths.client.styles) | |||
There was a problem hiding this comment.
We don't want this change. The 'styles' task should only used if you pick a CSS transpiler
There was a problem hiding this comment.
Could you propose an alternative fix to the problem I reported?
There was a problem hiding this comment.
<%_ if(!filters.css) { _%>
return gulp.src(paths.client.mainStyle)
<%_ } else { _%>
return gulp.src(paths.client.styles)<% } %>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add all css files to the css injector, for some reason the hardcoded glob wouldn't work but I instead used the predefined one. All css files now also undergo the 'styles' pipe.
The problem this fixes is that only
app.cssused to be loaded, because it was the only one injected intoindex.html.