Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove hardcoded socket connection url in klingon ui #58

Closed
sumitparakh opened this issue Sep 30, 2018 · 1 comment
Closed

remove hardcoded socket connection url in klingon ui #58

sumitparakh opened this issue Sep 30, 2018 · 1 comment
Labels
triage

Comments

@sumitparakh
Copy link
Member

sumitparakh commented Sep 30, 2018 •
edited
Loading

I've just switched from windows 10 to linux (kali) and when i ran the project. I found that there was another service(Apache Test) which was using 3000 port. So klingon server threw "port in use" error.

So i've changed server port from 3000 to 3001 and it worked.
But then, klingon-ui threw 404 error because localhost:3000 was hardcoded in it.. So i had to update the port at 4-5 locations in klingon-ui. It is a bit time taking.

I think we should define scheme, host and port values in environment file so that it is reused across klingon-ui and reduce hardcoding.
@sumitparakh sumitparakh changed the title Sync socket connection url in angular ui remove hardcoded socket connection url in klingon ui Sep 30, 2018
sumitparakh added a commit to sumitparakh/klingon that referenced this issue Sep 30, 2018
@sumitparakh
fix(ui): removed hardcoded socket connection url
b957c68 
reuse url variables across klingon-ui through envirtonment.

Fixed angular-klingon#58
sumitparakh added a commit to sumitparakh/klingon that referenced this issue Sep 30, 2018
@sumitparakh
fix(ui): removed hardcoded socket connection url
c0e2485 
reuse url variables across klingon-ui through envirtonment.

Fixed angular-klingon#58
sumitparakh added a commit to sumitparakh/klingon that referenced this issue Sep 30, 2018
@sumitparakh
fix(ui): removed hardcoded socket connection url
6fae74a 
reuse url variables across klingon-ui through envirtonment.

Fixed angular-klingon#58
sumitparakh added a commit to sumitparakh/klingon that referenced this issue Sep 30, 2018
@sumitparakh
fix(ui): removed hardcoded socket connection url
4901f45 
reuse url variables across klingon-ui through environment.

Fixed angular-klingon#58
sumitparakh added a commit to sumitparakh/klingon that referenced this issue Sep 30, 2018
@sumitparakh
fix(ui): Removed hardcoded socket connection url
7162a87 
Reuse url variables across klingon-ui through environment.

Fixed angular-klingon#58
sumitparakh added a commit to sumitparakh/klingon that referenced this issue Sep 30, 2018
@sumitparakh
fix(ui):Removed hardcoded socket connection url
8899175 
Reuse url variables across klingon-ui through environment.

Fixed angular-klingon#58
sumitparakh added a commit to sumitparakh/klingon that referenced this issue Sep 30, 2018
@sumitparakh
fix(ui): Removed hardcoded socket connection url
d07b882 
Reuse url variables across klingon-ui through environment

Fixed angular-klingon#58
sumitparakh added a commit to sumitparakh/klingon that referenced this issue Sep 30, 2018
@sumitparakh
fix(ui): Removed hardcoded socket connection url
a2a189b 
Reuse url variables across klingon-ui through environment

Fixed angular-klingon#58
@sumitparakh sumitparakh mentioned this issue Sep 30, 2018
Merged
@sumitparakh
Copy link
Member Author

Fix #60

manekinekko pushed a commit that referenced this issue Oct 1, 2018
@sumitparakh @manekinekko
fix(ui): Removed hardcoded socket connection url
2130a3d 
Reuse url variables across klingon-ui through environment

Fixed #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sumitparakh