Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Local workspace file ('angular.json') could not be found #72

Closed
sumitparakh opened this issue Nov 23, 2018 · 0 comments
Closed

Bug: Local workspace file ('angular.json') could not be found #72

sumitparakh opened this issue Nov 23, 2018 · 0 comments
Assignees
@sumitparakh
Labels
effort1: easy (hours) package: @klingon/ui priority: high First Priority type: bug

Comments

@sumitparakh
Copy link
Member

sumitparakh commented Nov 23, 2018 •
edited
Loading

Describe the bug
Getting Location workspace file ('angular.json') could not be found while trying to serve application

Screenshots
angularjsonnotfound

Additional context
Problem is, everytime it is trying to serve application from home directory where app doesn't exist. Hence command fails.

Proposed Solution
There should be an option to specify root dir in serve tab and make application field mandatory. Once user enter root dir and application name, we can pass it as current working directory to the cli command. Note msg.dir here:-
https://github.com/angular-klingon/klingon/blob/master/packages/klingon-server/terminal.js#L60

Related to #6
@sumitparakh sumitparakh self-assigned this Nov 23, 2018
sumitparakh added a commit to sumitparakh/klingon that referenced this issue Nov 23, 2018
@sumitparakh
Bug: Local workspace file ('angular.json') could not be found
6234a5a 
Added root directory, made application field mandatory

Fixes angular-klingon#72
@sumitparakh sumitparakh mentioned this issue Nov 23, 2018
Merged
sumitparakh added a commit to sumitparakh/klingon that referenced this issue Nov 23, 2018
@sumitparakh
bug(serve): Local workspace file ('angular.json') could not be found
82a369c 
Added root directory, made application field mandatory

Fixes angular-klingon#72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sumitparakh sumitparakh

Labels
effort1: easy (hours) package: @klingon/ui priority: high First Priority type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sumitparakh