Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Introducing Brian's ngmin #20

Closed
0x-r4bbit opened this issue May 2, 2013 · 6 comments
Closed

Introducing Brian's ngmin #20

0x-r4bbit opened this issue May 2, 2013 · 6 comments
Assignees
Milestone

Comments

@0x-r4bbit
Copy link
Member

Because we want to save key strokes!

@ghost ghost assigned 0x-r4bbit May 2, 2013
@0x-r4bbit 0x-r4bbit mentioned this issue May 2, 2013
29 tasks
@ajoslin
Copy link

ajoslin commented May 3, 2013

I actually don't think ngmin is a good step for these kind of components.

It can really mess up users if they want to use their own minification step on their libs, and don't use ngmin. It's happened to me and I'm sure some other people.

@0x-r4bbit
Copy link
Member Author

What do you mean? The ngmin task gets executed before somebody get his hands dirty on ngTranslate. It's just for development purposes.

@0x-r4bbit
Copy link
Member Author

Which means, if you use ngTranslate, the source is already annotated :)

@ajoslin
Copy link

ajoslin commented May 3, 2013

Ah, so you still distribute ng-translate.js ng-min'd. Duh :-)

@ajoslin
Copy link

ajoslin commented May 3, 2013

Haha for some reason I always did it I only ng-min'd if I was going to minify.

@0x-r4bbit
Copy link
Member Author

Yeah, so as long as you develop on ngTranslate and just use watch task, nothing happens. When you're ready to generate a production ready files, you'd run grunt build which concatenates the source, runs ngmin on it and uglifies it afterwards.

In the end you have to files. Both are annotated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants