Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

0.13.2 - When a button-checkbox's ng-disabled is false, model doesn't change when clicking #4088

Closed
starf opened this issue Aug 3, 2015 · 2 comments
Closed

0.13.2 - When a button-checkbox's ng-disabled is false, model doesn't change when clicking #4088

starf opened this issue Aug 3, 2015 · 2 comments
Labels
component: buttons type: bug
Milestone
0.13.3 (Fixes)

Comments

@starf
Copy link

starf commented Aug 3, 2015

when (checkbox/radio) button's ng-disabled has a false value, clicking it does not change the model

problem occured after switching to 0.13.2 (worked OK in 0.13.1)

see plunkr: http://plnkr.co/edit/hjcmk0fNvRVjD0rFJjAG?p=preview
@starf starf changed the title 0.13.2 - When a button-checkbox's ng-disabled="false" it should work 0.13.2 - When a button-checkbox's ng-disabled is false, model doesn't change Aug 3, 2015
@starf starf changed the title 0.13.2 - When a button-checkbox's ng-disabled is false, model doesn't change 0.13.2 - When a button-checkbox's ng-disabled is false, model doesn't change when clicking Aug 3, 2015
@wesleycho
Copy link
Contributor

Good catch - @RobJacobs looks like your observation about 'disabled' in attrs was on point. Changing to !attrs.disabled there fixes it, as can be seen here.

@wesleycho wesleycho added this to the 0.13.3 (Performance) milestone Aug 3, 2015
@wesleycho
Copy link
Contributor

Just a note, I may do a mid-week release in order to get this fix and another out there.

@wesleycho wesleycho mentioned this issue Aug 4, 2015
Closed
wesleycho added a commit that referenced this issue Aug 4, 2015
@wesleycho
fix(buttons): change to use attrs.disabled
c9b0d0b 
- Change to use `attrs.disabled`

Fixes #4088
@davideberlein davideberlein mentioned this issue Aug 6, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: buttons type: bug
Projects
None yet
Milestone
0.13.3 (Fixes)
Development

No branches or pull requests
2 participants
@starf @wesleycho