This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(datepicker): focus input on keyboard selection in popup #4409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed the focusElement call from keydown handler so that the control is not focused after selecting a date with the keyboard.
|
Looking at an accessibility example here, it looks like this agrees with the example, which is desired. This LGTM. |
jasonaden
pushed a commit
to deskfed/bootstrap
that referenced
this pull request
Jan 8, 2016
BREAKING CHANGE: Removes focus on datepicker on selection of a date via keyboard for accessibility reasons Closes angular-ui#4409
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed the
focusElement()call from keydown handler so that the popup control is not focused after selecting a date with the keyboard. instead, the focus stays with the input, as called fromdateSelected()