This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(carousel): Better a11y with sr-only text and markup structure #4479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <a class="right carousel-control" ng-click="next()" ng-show="slides.length > 1"><span class="glyphicon glyphicon-chevron-right"></span></a> | ||
| </div> | ||
| <div class="carousel-inner" ng-transclude></div> | ||
| <a role="button" href="#" class="left carousel-control" ng-click="prev()" ng-show="slides.length > 1"> |
There was a problem hiding this comment.
This needs to be an empty href due to some edge cases
|
Other than those two small issues that we can fix on merge, I'm fine with this. |
|
Sweet! |
jasonaden
pushed a commit
to deskfed/bootstrap
that referenced
this pull request
Jan 8, 2016
- Improves accessibility of carousel Closes angular-ui#4478 Closes angular-ui#4479
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4478