Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(datepicker): min-date: parse using displayFormat #5104

Closed
wants to merge 1 commit into from
Closed

fix(datepicker): min-date: parse using displayFormat #5104

wants to merge 1 commit into from

Conversation

davious
Copy link
Contributor

@davious davious commented Dec 21, 2015

Closes #3570

Review on Reviewable

@davious davious force-pushed the datepicker-parse-min-date branch 2 times, most recently from 43948de to 6c9ad63 Compare December 21, 2015 03:11
@wesleycho
Copy link
Contributor

This is in need of rebasing off of current master

wesleycho
wesleycho reviewed Jan 9, 2016
View reviewed changes
src/datepicker/datepicker.js
if (!isNaN(date)) {
return date;
}
date = new Date(dateFilter(viewValue, 'MMM d, y h:mm:ss.sss a'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what format the viewValue could it be in this stage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a carryover of @07e0970. The format would be yyyy-MM-dd, for example.

@davious davious force-pushed the datepicker-parse-min-date branch 4 times, most recently from 4d5ff65 to 6de4cd3 Compare January 17, 2016 15:08
@davious
Copy link
Contributor Author

davious commented Mar 5, 2016

This is rebased. I welcome a review.

@wesleycho
Copy link
Contributor

As per #5658, we intend on removing all literal support in 1.4.0 & intend to deprecate in 1.3.0 - on some datepicker work, we are finding quite a bit of bloat of having to duplicate unnecessarily complex conditionals/fallbacks for the fragile dual model of literals, and it is slowing down work significantly.

Going to close this in light of this decision & highly recommend transitioning to JS dates.

@wesleycho wesleycho closed this Mar 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
component: datepicker needs: rebasing needs: review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davious @wesleycho