Skip to content

Commit

Permalink
fix(concat): only load ui-grid files once
Browse files Browse the repository at this point in the history
This should both fix the size of the ui-grid.js file and the broken selection feature.

fix #6927, fix #6928
  • Loading branch information
Portugal, Marcelo authored and mportuga committed Feb 7, 2019
1 parent 678b85f commit eb98748
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion grunt/concat.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const templateDirectories = getTemplateDirectories('packages/');

function getFiles() {
const files = {
'<%= dist %>/release/<%= pkg.name %>.js': ['packages/core/src/js/bootstrap.js', 'packages/**/src/js/**/*.js', '.tmp/template.js'],
'<%= dist %>/release/<%= pkg.name %>.js': ['packages/core/src/js/bootstrap.js', 'packages/*/src/js/**/*.js', '.tmp/template.js'],
'packages/core/js/<%= pkg.name %>.core.js': ['src/js/core/bootstrap.js', 'packages/core/src/js/**/*.js', '.tmp/template-core.js']
};
const packages = getDirectories('packages/');
Expand Down

3 comments on commit eb98748

@nathanbeach
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! we just upgraded from 4.0.2 to 4.7.0 and i was banging my head trying to figure out what was going on with that row selection error (also found it odd the file size increased so much). thanks for the fix...

@mportuga
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nateabele It is amazing how much one little character can mess things up so much. Sorry for the trouble I caused. I need to be more careful next time.

@nathanbeach
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've been there! thanks...

Please sign in to comment.