-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boolean type Edit by clicking issue on Firefox/Safari #1785
Comments
That's interesting. The behaviour I see in Safari is that I double click on the field, which brings up the editable checkbox. But when I then single click on the field it seems to immediately lose focus rather than toggle the value - so something is stealing the click from the checkbox. Is that the behaviour you're seeing? The dropdown and the number editor are accepting clicks. The date editor doesn't appear to be showing for the date field - I get just a standard input field. |
yes, that's exactly it, seems ok in Chrome though... |
I think the problem is html5 widgets - and the fact that Safari and IE don't implement some of the html5 widget types. Does that sound correct? |
Closing, no further comments for 2 weeks, and no plausible path to a resolution using the vanilla widgets. Could be addressed with custom templates. |
Thanks Paul, decided against using the Boolean type altogether now |
Anyone know how to resolve this? Custom templates or not. I'm willing to contribute code if anyone knows where the issue lies. |
Add mousedown listener to ui.grid.edit.directive:uiGridEditor to disable blur handler if the element is a checkbox, and then re-focus the checkbox and enable the blur handler after a $timeout. This change is to deal with Safari and Firefox behavior in macOS where clicking the checkbox causes a blur event, and the value is not updated. GitHub issues: angular-ui#1785, angular-ui#4778, angular-ui#4782
From the Edit Feature tutorial http://ui-grid.info/docs/#/tutorial/201_editable on Firefox/Safari, the Active column's boolean value is not changeable by clicking. It can only be edited when in focus using the spacebar. The checkbox appears to work fine on Chrome using clicks.
The text was updated successfully, but these errors were encountered: