Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters Text-box ( ui-grid-filter-input ) Overlaps "X" Button ( ui-grid-icon-cancel ) #5051

Closed
Yashkochar20 opened this issue Feb 1, 2016 · 2 comments · Fixed by #6548
Closed

Comments

@Yashkochar20
Copy link

Actual: Attached is a screenshot of the issue. When input text length is longer than the size of the search box, the text and the "X" button overlap.

I would expect 'X' to stay locked and when user enters a long name bigger than length of search field, the field scrolls to the right and the text at the beginning of the input text box starts to get hidden as it moves to the left (which is actual now just that the 'X' button is not locked and overlaps the characters)

screen shot 2016-02-01 at 1 51 19 pm

@islamgamal
Copy link

+1
image

@tentux-dash
Copy link

Issue still present in v4.0.4. @Yashkochar20 has suggested the text within the input field should simply stop short of the cancel button (small X) to prevent the text from overlapping. This can be achieved by adding some padding-right to the input field within Chrome.

However, I feel the cancel button / small cross should be next to the input field (on the right) and not within the bounds of the input field / textbox - this would be consistent with how dropdown lists (select) appear within the filter, as here the cancel button is next to the select element on the right hand side.

mportuga pushed a commit that referenced this issue Jan 20, 2018
Fixed some of the more blatant issues of overlap between the grid menu and the last visible column,
although some issues remain with the timing of the digest cycle. Also, updated the grid menu styles
a bit based on some CSS suggestions.

fix #4337, fix #5051, fix #5557
mportuga pushed a commit that referenced this issue Jan 20, 2018
Fixed some of the more blatant issues of overlap between the grid menu and the last visible column,
although some issues remain with the timing of the digest cycle. Also, updated the grid menu styles
a bit based on some CSS suggestions.

fix #4337, fix #5051, fix #5557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants