Second attempt to fix #777, still ensuring the rendering row count is sensible #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w count is sensible - just using a correct interpretation
|
Our testing team has passed this as a fix for issue #777 - please can this be pulled into the main repo? |
roblarsen
added a commit
that referenced
this pull request
Dec 3, 2013
Second attempt to fix #777, still ensuring the rendering row count is sensible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original issue was that when filtering dropped the filtered row count to under the virtualisation limit the formula used gave the total data source length as a result, leading to potentially very large numbers of rendered rows.
The first attempt to fix misinterpreted the role of various variables, and was incorrect. This led to parts of the grid not rendering under some circumstances.
This fix corrects that misunderstanding, and reverts the original formula but substituting
filteredRows.lengthfordata.lengthstill avoiding the rendering of the data source length number of rows.