This repository has been archived by the owner on Sep 8, 2020. It is now read-only.
attempts to fix an issue with modelViewValue, addresses an issue with… #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… extra character input, addresses an issue with passing eventsToHandle in ui-options, fixes test and demo for changes
Model View Value
I propose a slight change for the model-view-value implementation. It shouldn't update the model with a trailing mask. For example:
for view value (999) 123-123_ X____
model value should be: (999) 123-123
Fix ui-options for eventsToHandle
This wasn't working, I think, because of a bug in the code. I made an attempt to fix it. To summarize the fix, ui-mask was extending the passed in options with the base and eventsToHandle was being overwritten.
Prevent model update on focus when there are no changes being made
The event handler was updating the model on focus (by calling setViewValue) even if there was no user input.
Updated demo page and fixed a test
I updated the demo page so that you can test model view value and eventsToHandle.