fix(uiSrefActive): annotate controller function #671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current version is not working in minified version. It need explicit $inject to make it work
mfield
pushed a commit
to mfield/ui-router
that referenced
this pull request
Dec 21, 2013
longprao
added a commit
to longprao/ui-router
that referenced
this pull request
Dec 31, 2013
Added to release/angular-ui-router.js file. Current version is not working in minified version. angular-ui#671 already fixed it but not in release.
|
Please update |
|
@tomchentw When we do a release, it will be. |
|
@nateabele yeah see that's what I originally thought, but everyone is making me think we somehow forgot to do something. |
|
@nateabele: could you give us some indication of when this fix will be released? The uiSrefActive feature is now unusable in production code. |
|
I guess that would be true if Bower were the only way to get a production build. |
|
+1 @thvd |
|
seems has been fixed on 0.2.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version is not working in minified version. It need explicit $inject to make it work