Skip to content

Commit

Permalink
feat(@angular/cli): update webpack to latest version
Browse files Browse the repository at this point in the history
We dont want this in 1.3.x, so marking as a feature.
  • Loading branch information
hansl committed Aug 25, 2017
1 parent 9fa4ab0 commit c40624b
Show file tree
Hide file tree
Showing 4 changed files with 51 additions and 44 deletions.
65 changes: 35 additions & 30 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,10 @@
"stylus-loader": "^3.0.1",
"typescript": "~2.4.2",
"url-loader": "^0.5.7",
"webpack": "~3.4.1",
"webpack": "~3.5.5",
"webpack-concat-plugin": "1.4.0",
"webpack-dev-middleware": "^1.11.0",
"webpack-dev-server": "~2.5.1",
"webpack-dev-middleware": "~1.12.0",
"webpack-dev-server": "~2.7.1",
"webpack-merge": "^4.1.0",
"zone.js": "^0.8.14"
},
Expand Down
6 changes: 3 additions & 3 deletions packages/@angular/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,10 @@
"stylus-loader": "^3.0.1",
"typescript": ">=2.0.0 <2.5.0",
"url-loader": "^0.5.7",
"webpack": "~3.4.1",
"webpack": "~3.5.5",
"webpack-concat-plugin": "1.4.0",
"webpack-dev-middleware": "^1.11.0",
"webpack-dev-server": "~2.5.1",
"webpack-dev-middleware": "~1.12.0",
"webpack-dev-server": "~2.7.1",
"webpack-merge": "^4.1.0",
"zone.js": "^0.8.14"
},
Expand Down
18 changes: 10 additions & 8 deletions tests/e2e/tests/misc/public-host.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,16 @@ export default function () {
const localAddress = `http://${publicHost}`;

return Promise.resolve()
.then(() => ngServe('--host=0.0.0.0'))
.then(() => request(localAddress))
.then(body => {
if (!body.match(/Invalid Host header/)) {
throw new Error('Response does not match expected value.');
}
})
.then(() => killAllProcesses(), (err) => { killAllProcesses(); throw err; })
// Disabling this test. Webpack Dev Server does not check the hots anymore when binding to

This comment has been minimized.

Copy link
@sajidali

sajidali Aug 29, 2017

Webpack Dev Server does not check the host anymore

// numeric IP addresses.
// .then(() => ngServe('--host=0.0.0.0'))
// .then(() => request(localAddress))
// .then(body => {
// if (!body.match(/Invalid Host header/)) {
// throw new Error('Response does not match expected value.');
// }
// })
// .then(() => killAllProcesses(), (err) => { killAllProcesses(); throw err; })
.then(() => ngServe('--host=0.0.0.0', `--public-host=${publicHost}`))
.then(() => request(localAddress))
.then(body => {
Expand Down

0 comments on commit c40624b

Please sign in to comment.