fix(@angular/cli): ng get: return whole config root when no path provided. #5887
Conversation
| @@ -11,7 +11,7 @@ export interface GetOptions { | |||
|
|
|||
| const GetCommand = Command.extend({ | |||
| name: 'get', | |||
| description: 'Get a value from the configuration.', | |||
| description: 'Get a value from the configuration. Example: ng get project.name', | |||
There was a problem hiding this comment.
@prestonvanloon Please change this to match format eg. "ng new [name]".
tests/e2e/tests/commands/get/get.ts
Outdated
| @@ -4,6 +4,7 @@ import {expectToFail} from '../../../utils/utils'; | |||
| export default function() { | |||
| return Promise.resolve() | |||
| .then(() => expectToFail(() => ng('get', 'apps.zzz.prefix'))) | |||
| .then(() => expectToFail(() => ng('get', undefined))) | |||
There was a problem hiding this comment.
This should be just ng('get') as ng get undefined seems to be working fine already as it is converted to string key.
|
I think this should be closed in favor of returning the whole config object when no param specified. I'll submit a new PR later. |
|
Or this PR modified to return the whole object. Not sure what is preferred. |
prestonvanloon
changed the title
|
I updated this PR title, description, and content with the changes outlined in my previous comment. |
|
Heya @prestonvanloon thanks for the work here. Can you rebase this PR? There's a couple of CI errors that were due to changes on our side, but it should be fine now. |
|
@filipesilva OK. Should be all good now. Thanks! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Running
ng getwithout a config key would throw ainvalidJsonPatherror rather than a meaningful message.This PR
JSON.stringify(value, null, 2).Fixes #5886