Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the version of karma-covrage-istanbul-reporter #6191

Closed
yfain opened this issue May 5, 2017 · 2 comments
Closed

Upgrade the version of karma-covrage-istanbul-reporter #6191

yfain opened this issue May 5, 2017 · 2 comments
Assignees
Labels
effort1: easy (hours) P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@yfain
Copy link

yfain commented May 5, 2017

- [ ] bug report -> please search issues before submitting
- [x ] feature request

Angular CLI 1.0.1 generates package.json that include an old version of the coverage plugin:

    "karma-coverage-istanbul-reporter": "^0.2.0"

As a result, trying to set the thresholds for coverage doesn't work. Upgrade this dependency to

    "karma-coverage-istanbul-reporter": "^1.2.0"

This will allow to make the tests with low coverage fail by adding thresholds to karma.conf.js, for example:

coverageIstanbulReporter: {
      reports: ['html', 'lcovonly'],
      fixWebpackSourcePaths: true,
      thresholds: {
        global: { // thresholds for all files
          statements: 80,
          lines: 80,
          branches: 80,
          functions: 80
        },
        each: { // thresholds per file
          statements: 80,
          lines: 80,
          branches: 80,
          functions: 80
        }
      }
    }
@filipesilva filipesilva self-assigned this May 8, 2017
@filipesilva filipesilva added type: enhancement effort1: easy (hours) P5 The team acknowledges the request but does not plan to address it, it remains open for discussion labels May 8, 2017
@filipesilva
Copy link
Contributor

Fixed by #5519, which should get the latest version.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort1: easy (hours) P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Development

No branches or pull requests

2 participants