-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.1.0-rc.0 regression: wrong library bundled #6351
Comments
It is both reproducible with |
I believe I found where the error is coming from. I captured the chunks emitted by the dev server for both beta 1 and rc 0 and compared them. My usage of libraries as like this:
With beta 1 I see in my chunk:
With rc 0, the same chunk only has one difference:
It therefore takes the library |
So it's this change causing the issue: #6276 |
What you are seeing is the correct behavior exposing a defect in either the dependency configuration of the project or one of the dependencies (in this case |
You are of course right. I've relaxed the openlayers dependency to
Which is broad enough for users of the package and now rc 0 bundles the correction version of the library. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug Report or Feature Request (mark with an
x
)Versions.
@angular/cli: 1.1.0-rc.0
node: 6.10.2
os: linux x64
@angular/common: 4.1.2
@angular/compiler: 4.1.2
@angular/core: 4.1.2
@angular/forms: 4.1.2
@angular/http: 4.1.2
@angular/platform-browser: 4.1.2
@angular/platform-browser-dynamic: 4.1.2
@angular/router: 4.1.2
@angular/cli: 1.1.0-rc.0
@angular/compiler-cli: 4.1.2
-->
Repro steps.
My project bundles OpenLayers which is a monolithic JavaScript created by Closure compiler. With 1.1.0-rc.0 (but not any version before including up to 1.1.0-beta.1), it seems that incorrect code is emitted leading to a runtime error deep down in the library. From the looks of it, an identifier is not defined -- possibly incorrect tree-shaking?
I can reproduce it at will but given the complexity of the project, I am a bit at loss as to how to proceed the investigation.
The text was updated successfully, but these errors were encountered: