fix(NgForm): use map notation for controls and dot notation for instance properties

Author: matsko

lib/directive/ng_form.dart

@@ -22,7 +22,7 @@ part of angular.directive;
     publishTypes : const <Type>[NgControl],
     map: const { 'ng-form': '@name' },
     visibility: NgDirective.CHILDREN_VISIBILITY)
-class NgForm extends NgControl implements Map<String, NgControl> {
+class NgForm extends NgControl {
   /**
    * Instantiates a new instance of NgForm. Upon creation, the instance of the
    * class will be bound to the formName property on the scope (where formName
@@ -57,56 +57,10 @@ class NgForm extends NgControl implements Map<String, NgControl> {
     }
   }
 
-  //FIXME: fix this reflection bug that shows up when Map is implemented
-  operator []=(String key, value) {
-    if (key == 'name') {
-      name = value;
-    } else {
-      _controlByName[key] = value;
-    }
-  }
-
-  //FIXME: fix this reflection bug that shows up when Map is implemented
-  operator[](name) {
-    if (name == 'valid') {
-      return valid;
-    } else if (name == 'invalid') {
-      return invalid;
-    } else {
-      return _controlByName[name];
-    }
-  }
-
-  bool get isEmpty => false;
-  bool get isNotEmpty => !isEmpty;
-  get values => null;
-  get keys => null;
-  get length => null;
-  clear() => null;
-  remove(_) => null;
-  containsKey(_) => false;
-  containsValue(_) => false;
-  addAll(_) => null;
-  forEach(_) => null;
-  putIfAbsent(_, __) => null;
+  NgControl operator[](name) => _controlByName[name];
 }
 
 class NgNullForm extends NgNullControl implements NgForm {
   NgNullForm() {}
-
   operator[](name) {}
-  operator []=(String name, value) {}
-
-  bool get isEmpty => false;
-  bool get isNotEmpty => true;
-  get values => null;
-  get keys => null;
-  get length => null;
-  clear() => null;
-  remove(_) => null;
-  containsKey(_) => false;
-  containsValue(_) => false;
-  addAll(_) => null;
-  forEach(_) => null;
-  putIfAbsent(_, __) => null;
 }

test/directive/ng_form_spec.dart

@@ -483,6 +483,24 @@ void main() {
       }));
     });
 
+    it("should use map notation to fetch controls", inject((TestBed _) {
+        Scope s = _.rootScope;
+        s.context['name'] = 'cool';
+
+        var form = _.compile('<form name="myForm">' +
+                             ' <input type="text" ng-model="someModel" probe="i" name="name" />' +
+                             '</form>');
+
+        NgForm formModel = s.context['myForm'];
+        Probe probe = s.context['i'];
+        var model = probe.directive(NgModel);
+
+        expect(s.eval('name')).toEqual('cool');
+        expect(s.eval('myForm.name')).toEqual('myForm');
+        expect(s.eval('myForm["name"]')).toBe(model);
+        expect(s.eval('myForm["name"].name')).toEqual("name");
+    }));
+
     describe('regression tests: form', () {
       it('should be resolvable by injector if configured by user.', () {
         module((Module module) {