Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Commit d6b9bb7

Browse files
mvuksanomhevery
authored andcommitted
perf(DirtyCheckingChangeDetectorGroup): Disable calls to _assertRecordsOk().
Disabled calls to _assertRecordsOk function as it is too slow. Closes #813
1 parent c852720 commit d6b9bb7

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

lib/change_detection/dirty_checking_change_detector.dart

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,8 @@ class DirtyCheckingChangeDetectorGroup<H> implements ChangeDetectorGroup<H> {
124124
* Create a child [ChangeDetector] group.
125125
*/
126126
DirtyCheckingChangeDetectorGroup<H> newGroup() {
127-
assert(_root._assertRecordsOk());
127+
// Disabled due to issue https://github.com/angular/angular.dart/issues/812
128+
// assert(_root._assertRecordsOk());
128129
var child = new DirtyCheckingChangeDetectorGroup(this, _fieldGetterFactory);
129130
if (_childHead == null) {
130131
_childHead = _childTail = child;
@@ -133,7 +134,8 @@ class DirtyCheckingChangeDetectorGroup<H> implements ChangeDetectorGroup<H> {
133134
_childTail._next = child;
134135
_childTail = child;
135136
}
136-
assert(_root._assertRecordsOk());
137+
// Disabled due to issue https://github.com/angular/angular.dart/issues/812
138+
// assert(_root._assertRecordsOk());
137139
return child;
138140
}
139141

0 commit comments

Comments
 (0)