fix(cache): Make UnboundedCache extend Cache

[vicb]

The Cache implements concrete methods then we should extends it, not implements it

This fix an analyzer warning

Warning: 'FakeCache' doesn't implement 'Cache<String, HttpResponse> clear inherited from Cache<String, HttpResponse>' declared in 'Cache<String, HttpResponse>'.
Try adding an implementation of 'clear' or declaring 'FakeCache' to be 'abstract'.
class FakeCache extends UnboundedCache<String, HttpResponse> {
^^^^^
packages/angular/cache/cache.dart:42:8:
Info: The method 'clear' is declared here in class 'Cache'.
  void clear() => removeAll();
       ^^^^^
base/test/core_dom/http_spec.dart:10:1:
Warning: 'FakeCache' doesn't implement the getter 'length' declared in 'Cache<String, HttpResponse>'.
Try adding an implementation of 'length' or declaring 'FakeCache' to be 'abstract'.
class FakeCache extends UnboundedCache<String, HttpResponse> {
^^^^^
packages/angular/cache/cache.dart:43:11:
Info: The getter 'length' is declared here in class 'Cache'.
  int get length => size;

/cc @jbdeboer

[jbdeboer]

Looks good to me, I will merge this today.

[jbdeboer]

This PR doesn't apply to the g3v1x at the moment.

https://travis-ci.org/angular/angular.dart/jobs/28451827

[jbdeboer]

That is due to missing 9651c87 in g3v1x. I will merge that in tomorrow which should unblock this change

[jbdeboer]

@vicb: This should be good to merge to master now.

[vicb]

Thanks. Can you handle that ?

On July 3, 2014 6:18:01 PM CEST, James deBoer notifications@github.com wrote:

@vicb: This should be good to merge to master now.

---

Reply to this email directly or view it on GitHub:
#1174 (comment)