This repository has been archived by the owner on Dec 4, 2017. It is now read-only.
feat(ts): moving dev guide 1 to TS. #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes plunker links as they don't support TS yet.
| @@ -39,41 +28,35 @@ | |||
| application. | |||
|
|
|||
| p. | |||
| The TypeScript setup includes System.js, a third-party open-source library that adds ES6 module loading functionality to browsers. This step isn't needed for the ES5 version. System requires mapping the code file paths to understand what to be load. | |||
| The TypeScript setup includes System.js, a third-party open-source library that adds ES6 module loading functionality to browsers. This step isn't needed for the ES5 version. | |||
|
|
|||
There was a problem hiding this comment.
The text talks about creating a main.ts file, but I suppose technically, the es5 example would be called main.js. I think this probably belongs in a note before the first code-box, something like "Although we work through the examples here in TypeScript, you can also use regular ES5. Click the ES5 link in any code box to see the ES5 JavaScript version. Note that in ES5, you'd want to name your files .js rather than .ts."
|
A few small nit-picks, otherwise LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes plunker links as they don't support TS yet.