Permalink
Browse files

fix(browser): prevent ie from getting into redirect loop

Closes #1075
Closes #1079
Closes #1085
  • Loading branch information...
1 parent 0d57f13 commit ffb270130a4aaf3ddc2eb9d6211b46e1da136184 @mhevery mhevery committed Jun 22, 2012
Showing with 9 additions and 0 deletions.
  1. +1 −0 src/ng/browser.js
  2. +8 −0 test/ng/browserSpecs.js
View
@@ -149,6 +149,7 @@ function Browser(window, document, $log, $sniffer) {
self.url = function(url, replace) {
// setter
if (url) {
+ if (lastBrowserUrl == url) return;
lastBrowserUrl = url;
if ($sniffer.history) {
if (replace) history.replaceState(null, '', url);
@@ -468,6 +468,14 @@ describe('browser', function() {
fakeWindow.location.href = "http://ff-bug/?single%27quote";
expect(browser.url()).toBe("http://ff-bug/?single'quote");
});
+
+ it('should not set URL when the URL is already set', function() {
+ var current = fakeWindow.location.href;
+ sniffer.history = false;
+ fakeWindow.location.href = 'dontchange';
+ browser.url(current);
+ expect(fakeWindow.location.href).toBe('dontchange');
+ });
});
describe('urlChange', function() {

0 comments on commit ffb2701

Please sign in to comment.