This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngTransclude): use fallback content if only whitespace is provided #15140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
bug
What is the current behavior? (You can also link to an open issue here)
Fallback content is used even if only whitespace is provided
What is the new behavior (if this is a feature change)?
Fallback content is not used if only whitespace is provided
Does this PR introduce a breaking change?
Yes
Please check if the PR fulfills these requirements
Other information:
If the transcluded content is only whitespace then we should use the
fallback content instead. This allows more flexibility in formatting
your HTML.
Closes #15077
BREAKING CHANGE:
Previously whitespace only transclusion would be treated as the transclusion
being "not empty", which meant that fallback content was not used in that
case.
Now if you only provide whitespace as the transclusion content, it will be
assumed to be empty and the fallback content will be used instead.
If you really do want whitespace then you can force it to be used by adding
a comment to the whitespace.