Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngTransclude): use fallback content if only whitespace is provided #15140

Closed
wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

bug

What is the current behavior? (You can also link to an open issue here)

Fallback content is used even if only whitespace is provided

What is the new behavior (if this is a feature change)?

Fallback content is not used if only whitespace is provided

Does this PR introduce a breaking change?

Yes

Please check if the PR fulfills these requirements

Other information:

If the transcluded content is only whitespace then we should use the
fallback content instead. This allows more flexibility in formatting
your HTML.

Closes #15077

BREAKING CHANGE:

Previously whitespace only transclusion would be treated as the transclusion
being "not empty", which meant that fallback content was not used in that
case.

Now if you only provide whitespace as the transclusion content, it will be
assumed to be empty and the fallback content will be used instead.

If you really do want whitespace then you can force it to be used by adding
a comment to the whitespace.

If the transcluded content is only whitespace then we should use the
fallback content instead. This allows more flexibility in formatting
your HTML.

Closes angular#15077

BREAKING CHANGE:

Previously whitespace only transclusion would be treated as the transclusion
being "not empty", which meant that fallback content was not used in that
case.

Now if you only provide whitespace as the transclusion content, it will be
assumed to be empty and the fallback content will be used instead.

If you really do want whitespace then you can force it to be used by adding
a comment to the whitespace.
@Narretz
Copy link
Contributor

Narretz commented Sep 15, 2016

LGTM :shipit:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transcluded content is not trimmed
3 participants