This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(testability): findBindings should escape binding expressions before ... #9600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re performing regexp Move the function to escape regexps to Angular.js, fix the link, and use it in the $$testability service. See angular#9595
|
the first line of the commit message is too long, otherwise LGTM |
|
I thought the limit was 100 for everything now?
|
| @@ -54,6 +54,7 @@ | |||
| "isBoolean": false, | |||
| "isPromiseLike": false, | |||
| "trim": false, | |||
| "escapeForRegexp": true, | |||
There was a problem hiding this comment.
I think this should be false here. To tell JSHint that in general this is readonly constant.
That is why it is overridden in Angular.js below to true where we actually set the value of it.
|
I shortened the commit message :-) and added a couple of tests for situations where there is a filter |
|
Thanks pete! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...performing regexp
Move the function to escape regexps to Angular.js, fix the link, and use it in
the $$testability service.
See #9595