This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngModel): do not throw if view value changes on destroyed scope #16585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could for example happen if updating the value is debounced (either by asynchronously calling `$setViewValue()` or via `ngModelOptions`). Fixes angular#16583
jbedard
approved these changes
May 30, 2018
This was referenced Jun 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
If the scope associted with an
NgModelControllerinstance is destroyed between the view value changing and actually calling$$debounceViewValueCommit(), an error is throwing when we try to checkthis.$$scope.$root.$$phase(since$roothas been set tonullas part of$destroy()).This could, for example, happen if updating the value is debounced either by asynchronously calling
$setViewValue()or viangModelOptions.See also #16583.
What is the new behavior (if this is a feature change)?
No error \o/
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Fix/Feature: [Docs](https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#documentation) have been added/updatedOther information:
Fixes #16583.