Skip to content

Commit 0049743

Browse files
alexeaglealxhub
authored andcommitted
fix(bazel): don't inline tslib into fesms (#23044)
PR Close #23044
1 parent 4e004f3 commit 0049743

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

packages/bazel/test/ng_package/core_package.spec.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,11 @@ describe('@angular/core ng_package', () => {
122122
it('should not be processed by tsickle', () => {
123123
expect(shx.cat('fesm5/core.js')).not.toContain('@fileoverview added by tsickle');
124124
});
125+
126+
it('should load tslib from external bundle', () => {
127+
expect(shx.cat('fesm5/core.js')).not.toContain('function __extends');
128+
expect(shx.cat('fesm5/core.js')).toMatch('import {.*__extends');
129+
});
125130
});
126131

127132

tools/defaults.bzl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def ng_module(name, tsconfig = None, entry_point = None, **kwargs):
4545
entry_point = "public_api.ts"
4646
_ng_module(name = name, flat_module_out_file = name, tsconfig = tsconfig, entry_point = entry_point, **kwargs)
4747

48-
def ng_package(name, readme_md = None, license_banner = None, **kwargs):
48+
def ng_package(name, readme_md = None, license_banner = None, globals = {}, **kwargs):
4949
if not readme_md:
5050
readme_md = "//packages:README.md"
5151
if not license_banner:
@@ -55,6 +55,9 @@ def ng_package(name, readme_md = None, license_banner = None, **kwargs):
5555
name = name,
5656
readme_md = readme_md,
5757
license_banner = license_banner,
58+
globals = dict(globals, **{
59+
"tslib": "tslib"
60+
}),
5861
replacements = PKG_GROUP_REPLACEMENTS,
5962
**kwargs)
6063

0 commit comments

Comments
 (0)