fix(ngClass): do not deconstruct classes on element removal #10303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pkozlowski-opensource @mhevery please review. |
| @@ -129,8 +129,6 @@ export class NgClass implements DoCheck, OnDestroy { | |||
| } | |||
| } | |||
|
|
|||
| ngOnDestroy(): void { this._cleanupClasses(this._rawClass); } | |||
There was a problem hiding this comment.
You need to also remove OnDestroy and a relevant import
|
Lgtm. This is safe to remove. It was there when we did view caching and it is no longer applicable. Safe to remove. |
Prior to this fix [ngClass] would remove all dynamic classes when destroyed. It's essential that classes are persisted such that remove-based animations will still be stylistically correct. This patch fixes this issue. Closes angular#10008 Closes angular#10303
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this fix [ngClass] would remove all dynamic classes
when destroyed. It's essential that classes are persisted such
that remove-based animations will still be stylistically correct.
This patch fixes this issue.
Closes #10008