Skip to content

Conversation

chuckjaz
Copy link
Contributor

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

The linker integration tests contain references to TestComponentBuilder.

What is the new behavior?

The references to TestComponentBuilder are removed from query_integration_spec.ts, regression_integration_spec.ts, security_integration_spec.ts, view_injector_integration_spec.ts

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

Other information:

Removed references to TestComponentBuilder from:
query_integration_spec.ts
regression_integration_spec.ts
security_integration_spec.ts
view_injector_integration_spec.ts

@chuckjaz chuckjaz force-pushed the TCB-query_intergration branch from 0b8507f to 05f2f61 Compare August 17, 2016 23:02
@juliemr juliemr added this to the 2.0.0-rc.6 milestone Aug 17, 2016
Removed references to TestComponentBuilder from:
  query_integration_spec.ts
  regression_integration_spec.ts
  security_integration_spec.ts
  view_injector_integration_spec.ts
@chuckjaz chuckjaz force-pushed the TCB-query_intergration branch from 05f2f61 to d4163ea Compare August 17, 2016 23:15
@@ -8,774 +8,629 @@

import {NgFor, NgIf} from '@angular/common';
import {AfterContentChecked, AfterContentInit, AfterViewChecked, AfterViewInit, Component, ContentChild, ContentChildren, Directive, QueryList, TemplateRef, ViewChild, ViewChildren, ViewContainerRef, asNativeElements} from '@angular/core';
import {TestBed, async} from '@angular/core/testing';
import {AsyncTestCompleter, TestComponentBuilder, beforeEach, ddescribe, describe, iit, inject, it, xit} from '@angular/core/testing/testing_internal';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line?

@IgorMinar IgorMinar added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Aug 17, 2016
@kara kara merged commit a5c0349 into angular:master Aug 17, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants