fix(router): update the location before activating components #11063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsavkin
added
the
action: review
vsavkin
force-pushed
the
router_fixes_25
branch
from
f5378eb to
ee6e9a4
Compare
robwormald
added
pr_state: LGTM
and removed
action: review
|
Can this PR be updated to fix the RouterLink that's not on anchor elements to be updated when a navigstion ends? It currently only updates in the RouterLinkWithHref |
|
@brandonroberts could you take care of that & rebase ? |
|
@vsavkin any chance you can rebase before our tomorrow ? |
vsavkin
force-pushed
the
router_fixes_25
branch
from
6afd5c0 to
a9d49db
Compare
|
CI fixed in #11102 |
vicb
added a commit
to vicb/angular
that referenced
this pull request
Aug 26, 2016
closes angular#11063 closes angular#11102
This was referenced Aug 28, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10909, #10845, #10827, #10704, #10930, #11004