feat(router): register NgModuleFactory objects. #11211
Conversation
|
|
| @@ -0,0 +1,95 @@ | |||
| /** | |||
There was a problem hiding this comment.
Why is this file here? I don't think it is part of the PR
There was a problem hiding this comment.
Yeah, botched merge.
mprobst
force-pushed
the
register-ngmodule
branch
from
fde9998 to
cac1b6f
Compare
|
PTAL, now with |
| @@ -107,6 +107,11 @@ export class Identifiers { | |||
| runtime: NgModuleInjector, | |||
| moduleUrl: assetUrl('core', 'linker/ng_module_factory') | |||
| }; | |||
| static RegisterLoadedModuleFn: IdentifierSpec = { | |||
| name: 'registerLoadedModule', | |||
There was a problem hiding this comment.
perhaps registerModuleFactory would be a better name?
|
One more rename, otherwise LGTM. |
mhevery
added
pr_state: LGTM
action: cleanup
|
Also LGTM from me. |
| * An opaque ID for this module, e.g. a name or a path. Used to identify modules in `getNgModule`. | ||
| * If left `undefined`, the `NgModule` will not be registered with `getNgModule`. | ||
| */ | ||
| id: string|undefined; |
There was a problem hiding this comment.
remove |undefined as that is not compatible with typescript 1.8
When lazily loading code, users need to be able to get hold of the NgModuleFactory. For SystemJS environments, the SystemJS registry serves this purpose. However other environments, such as modules compiled with Closure compiler, do not expose exports object or a path based registry. For these environments, `@NgModule` objects can include an identifier, and the loading code can then pass `loadModule(id).then(() => getNgModule(id))` to the router.
mprobst
force-pushed
the
register-ngmodule
branch
from
c85a39d to
4b0b23b
Compare
mprobst
force-pushed
the
register-ngmodule
branch
from
4b0b23b to
d673747
Compare
mprobst
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
When lazily loading code, users need to be able to get hold of the
NgModuleFactory. For SystemJS environments, the SystemJS registry serves
this purpose. However other environments, such as modules compiled with
Closure compiler, do not expose exports object or a path based registry.
For these environments,
@NgModuleobjects can include an identifier, andthe loading code can then pass
loadModule(id).then(() => getNgModule(id))to the router.