Skip to content

Fix benchpress for newest protractor and selenium #11451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 9, 2016
Merged

Fix benchpress for newest protractor and selenium #11451

merged 3 commits into from
Sep 9, 2016

Conversation

tbosch
Copy link
Contributor

@tbosch tbosch commented Sep 8, 2016

No description provided.

@tbosch
chore: update protractor and selenium-webdriver packages
21c2d76 
As `karma-jasmine` has a peer dependency on `jasmine-core@2.3`, but `jasmine` and `protractor` are using `jasmine-core@2.4` we need to add `jasmine-core@2.3` explicitly. Previously, the peer dependency was
satisfied by accident because npm deduped the dependency
for `jasmine-core@2.3` as top level dependency.

Note that the shrink-wrap files changes quite a bit because
of the deduping mechanism of npm.
@tbosch
Copy link
Contributor Author

tbosch commented Sep 9, 2016

Errors in e2e tests of webworkers:

TypeError: WebElementCondition did not resolve to a WebElement: [object Object]
        at TypeError (native)
        at /home/travis/build/angular/angular/node_modules/selenium-webdriver/lib/webdriver.js:722:17
        at ManagedPromise.invokeCallback_ (/home/travis/build/angular/angular/node_modules/selenium-webdriver/lib/promise.js:1379:14)
        at TaskQueue.execute_ (/home/travis/build/angular/angular/node_modules/selenium-webdriver/lib/promise.js:2913:14)
        at TaskQueue.executeNext_ (/home/travis/build/angular/angular/node_modules/selenium-webdriver/lib/promise.js:2896:21)
        at /home/travis/build/angular/angular/node_modules/selenium-webdriver/lib/promise.js:2775:27
        at /home/travis/build/angular/angular/node_modules/selenium-webdriver/lib/promise.js:639:7
        at process._tickCallback (node.js:401:9)
    From: Task: Run it("should echo messages") in control flow
        at Object.<anonymous> (/home/travis/build/angular/angular/node_modules/jasminewd2/index.js:79:14)
        at /home/travis/build/angular/angular/node_modules/jasminewd2/index.js:16:5
        at ManagedPromise.invokeCallback_ (/home/travis/build/angular/angular/node_modules/selenium-webdriver/lib/promise.js:1379:14)
        at TaskQueue.execute_ (/home/travis/build/angular/angular/node_modules/selenium-webdriver/lib/promise.js:2913:14)
        at TaskQueue.executeNext_ (/home/travis/build/angular/angular/node_modules/selenium-webdriver/lib/promise.js:2896:21)
        at /home/travis/build/angular/angular/node_modules/selenium-webdriver/lib/promise.js:2775:27
    From asynchronous test: 
    Error
        at Suite.<anonymous> (../../../../../../modules/playground/e2e_test/web_workers/message_broker/message_broker_spec.ts:28:3)
        at Object.<anonymous> (../../../../../../modules/playground/e2e_test/web_workers/message_broker/message_broker_spec.ts:13:1)
        at Module._compile (module.js:397:26)
        at Object.Module._extensions..js (module.js:404:10)
        at Module.load (module.js:343:32)
        at Function.Module._load (module.js:300:12)

@vicb vicb added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Sep 9, 2016
@vicb vicb added this to the Angular 2 Final milestone Sep 9, 2016
@evmar evmar merged commit f386cb4 into angular:master Sep 9, 2016
@tbosch tbosch deleted the update_protractor branch September 13, 2016 02:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
Angular 2 Final
Development

Successfully merging this pull request may close these issues.
4 participants
@tbosch @evmar @vicb @googlebot