feat(router): add support for ng1/ng2 migration #12160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsavkin
added
action: review
vsavkin
force-pushed
the
router_ng1_ng2
branch
2 times, most recently
from
8830d43 to
603c5ef
Compare
vicb
added
pr_state: LGTM
action: merge
|
Need to update the public API |
|
LGTM |
vsavkin
force-pushed
the
router_ng1_ng2
branch
from
603c5ef to
3d1dee6
Compare
btrigueiro
pushed a commit
to btrigueiro/angular
that referenced
this pull request
Oct 21, 2016
|
@vicb what's mean of "LGTM"? |
|
@finalxcode As far as I know, it stands for "Looks Good To Me". |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.