feat(datePipe): support narrow forms for month and weekdays #12297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -165,9 +166,19 @@ function digitCondition(prop: string, len: number): Intl.DateTimeFormatOptions { | |||
| result[prop] = len == 2 ? '2-digit' : 'numeric'; | |||
| return result; | |||
| } | |||
|
|
|||
| function nameCondition(prop: string, len: number): Intl.DateTimeFormatOptions { | |||
| var result: {[k: string]: string} = {}; | |||
| function nameCondition(prop: string, len: number): Intl.DateTimeFormatOptions { | ||
| var result: {[k: string]: string} = {}; | ||
| result[prop] = len < 4 ? 'short' : 'long'; | ||
| if (len < 4) { | ||
| if (len > 1) { |
There was a problem hiding this comment.
result[prop] = len > 1 ? 'short' : 'narrow';
| @@ -165,9 +166,19 @@ function digitCondition(prop: string, len: number): Intl.DateTimeFormatOptions { | |||
| result[prop] = len == 2 ? '2-digit' : 'numeric'; | |||
laskoviymishka
force-pushed
the
feat/date_pipe_narrow_week
branch
2 times, most recently
from
75c0d2b to
9e0fad7
Compare
laskoviymishka
force-pushed
the
feat/date_pipe_narrow_week
branch
from
9e0fad7 to
f302a40
Compare
vicb
added
pr_state: LGTM
action: merge
btrigueiro
pushed a commit
to btrigueiro/angular
that referenced
this pull request
Oct 21, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Narrow form not supported
What is the new behavior?
Narrow form is supported
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Closes #12294