fix(router): avoid router initialization for non root components #12338
Conversation
| // register a spy on a function that is called on each init | ||
| const spy = spyOn(r, 'resetRootComponentType').and.callThrough(); | ||
|
|
||
| // bootstrap the root app |
There was a problem hiding this comment.
Could you remove the comments? I think it is pretty clear what the test does.
| spy.calls.reset(); | ||
|
|
||
| // bootstrap a component that is not the root compnent | ||
| appRef.bootstrap(BootstrappableComponent); |
There was a problem hiding this comment.
The bootstrap method returns a component ref that can be destroyed. Could you make sure it works when the first component is destroyed?
There was a problem hiding this comment.
done.
this works because the destroyed component is removed from ApplicationRef.components and the next bootstrapped component is at index 0 of ApplicationRef.components. I have added a test for this.
vsavkin
added
the
action: cleanup
|
@vsavkin all done. the travis build fails because of invalid saucelab configurations :( |
|
Could you please squash & rebase ? |
|
@vicb done. |
vicb
added
action: merge
|
Thanks, should be merged today. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior?
If more than one component is bootstrapped the router is initialized more than once. see issues:
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
Other information:
@vsavkin This pr only solves the mentioned issues. I'm not quite sure. But I think a more general solution would be to make sure the listener for APP_BOOTSTRAP_LISTENER is only called once.