Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(forms): fix Validators.min/maxLength with FormArray #13095

Merged
merged 1 commit into from
Dec 12, 2016
Merged

fix(forms): fix Validators.min/maxLength with FormArray #13095

merged 1 commit into from
Dec 12, 2016

Conversation

DzmitryShylovich
Copy link
Contributor

@DzmitryShylovich DzmitryShylovich commented Nov 25, 2016 •
edited
Loading

Fixes #13089

cc @kara

@photostu
Copy link

photostu commented Dec 9, 2016

This gonna get any merge love?

@DzmitryShylovich
Copy link
Contributor Author

in 2017 I guess :)

@vicb vicb added area: forms action: review The PR is still awaiting reviews from at least one requested reviewer pr_state: LGTM labels Dec 9, 2016
kara
kara approved these changes Dec 12, 2016
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 12, 2016
@vicb vicb merged commit e9f307f into angular:master Dec 12, 2016
@DzmitryShylovich DzmitryShylovich deleted the gh/13089 branch December 12, 2016 19:18
vicb pushed a commit that referenced this pull request Dec 15, 2016
@vicb
fix(forms): fix Validators.min/maxLength with FormArray (#13095)
7383e4a 
Fixes #13089
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: forms cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validators.minLength(x) doesn't work on FormArray
5 participants
@DzmitryShylovich @photostu @kara @vicb @googlebot