fix(language-service): update to use CompilerHost from compiler-cli
#13189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbosch
reviewed
Dec 2, 2016
| @@ -0,0 +1,34 @@ | |||
| { | |||
| "compilerOptions": { | |||
There was a problem hiding this comment.
Why do we need this new tsconfig file?
There was a problem hiding this comment.
The default config does not produce files that are consumable from roll-up. This configuration creates a version of the module that can be rolled into the language service.
tbosch
reviewed
Dec 2, 2016
| let report = (message: string) => { | ||
| results.push( | ||
| <Diagnostic>{kind: DiagnosticKind.Error, span: declaration.declarationSpan, message}); | ||
| let report = (message: string, span?: Span) => { |
tbosch
added
action: cleanup
chuckjaz
force-pushed
the
ls-compiler-host
branch
from
437becd to
1989209
Compare
chuckjaz
added
action: merge
maxime-allex
pushed a commit
to Linkurious/angular
that referenced
this pull request
Dec 6, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
The language service used its own
StaticReflectorHostwhich didn't have the auto-upgrade of metadata so it only worked for 2.3.0 projects.What is the new behavior?
Use the compiler host from
compiler-cliwhich includes the auto-upgrade of metadata allowing it to work on all 2.x.x projects.Does this PR introduce a breaking change? (check one with "x")