feat(compiler) : i18n explicit ID

[maxime-allex]

Please check if the PR fulfills these requirements

• The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
See [i18n] enable control over translation message ID

What is the new behavior?
Developer can now use specific ID in translations by adding a new "parameter" in the i18n attribute :

<p i18n="meaning|description@id">foo</p>
<!-- i18n: meaning1|desc1@@id1 -->bar<!-- /i18n -->

will produce for XMB :

<msg id="id" meaning="meaning" description="description">foo</msg>
<msg id="id1" meaning="meaning1" description="description1">foo</msg>

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

[maxime-allex]

@vicb I created new PR, because I'm not very good at rebasing. Now you have a clean PR.

[vicb]

what do you think or renaming i18nInfo to msgInfo / msgMeta ?

[maxime-allex]

@vicb OK for msgMeta.

[vicb]

_parseMessageMeta would look better, WDYT ?

[vicb]

please return an obj now, would be clerarer

[vicb]

Please look for @@ first.

• split left part on | for m|d,
• right part is id

add const MEANING_SEPARATOR = "|" and const ID_SEPARATOR = "@@"

[vicb]

add trailing "," here please - and maybe move id first (this is the important part)

[vicb]

Thanks !

I have added a last round of comments.

To rebase, update your master branch from upstream (or origin whatever it is name) and do a git rebase master -i in your feature branch.
That's pretty easy, do not hesitate to ask if you need help.

Also please remove the WS before the colon in feat(..) : ..., thanks

[vicb]

Also we discussed about an issue/PR on the doc repo, any progress on that front ?

[maxime-allex]

@vicb see the angular.io PR => docs(compiler): add doc + examples for i18n explicit ID option

[vicb]

move the const at file level

[vicb]

simplify, something like:

const idIndex = i18n.indexOf(ID_SEPARATOR);
const [mAndD, id] = idIndex == -1 ?  [i18n, ''] : [i18n.slice(0, idIndex), i18n.slice(idIndex + 2)];
const descIndex = i18n.indexOf('|');
const [meaning, description] = descIndex == -1 ? ['', mAndD] : [mAndD.slice(0, descIndex), i18n.slice(descIndex + 1)];

return {meaning, description, id};

[vicb]

nit: "id only"

[vicb]

Thanks, this PRs looks good. Only a couple more changes before this can be merged.

[vicb]

Thanks! it should get in tomorrow.

[kibbled]

Would this feature allow us to set IDs in our HTML/XLF files and avoid having to maintain IDs changing?

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}