fix(language-service): remove incompletely used parameter from `creat… #13278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eLanguageServiceFromTypescript()` Fixes angular#13277
chuckjaz
added
the
action: review
vicb
reviewed
Dec 6, 2016
| private serviceHost: TypeScriptServiceHost; | ||
| private service: LanguageService; | ||
| private host: ts.LanguageServiceHost; | ||
|
|
||
| static 'extension-kind' = 'language-service'; | ||
|
|
||
| constructor(config: { | ||
| ts: typeof ts; host: ts.LanguageServiceHost; service: ts.LanguageService; | ||
| host: ts.LanguageServiceHost; service: ts.LanguageService; |
There was a problem hiding this comment.
should be "," instead of ";" ?
There was a problem hiding this comment.
Typescript accepts both here but I prefer using ; as it is more consistent.
vicb
added
pr_state: LGTM
and removed
action: review
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
createLanguageServiceFromTypescript()takes atypescriptparameter that it doesn't completely use as some places it uses this parameter and in other places it uses the imported TypeScript.What is the new behavior?
createLanguageServiceFromTypescript()no longer takes the typescript module as a parameter and will always use the imported version.Does this PR introduce a breaking change? (check one with "x")
Other information:
…eLanguageServiceFromTypescript()`
Fixes #13277