-
Notifications
You must be signed in to change notification settings - Fork 26.5k
fix(interfaces): Make ResponseOptionsArgs an interface #13708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(interfaces): Make ResponseOptionsArgs an interface As per the [Typescript Language Spec](https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#3.10) having it as an interface means extends, and implements keywords cannot be used. It is unclear why this was declared as a type in the first place
mhevery
approved these changes
Feb 10, 2017
Please fix PR to pass the CI. |
need to update the public API |
vicb
pushed a commit
to vicb/angular
that referenced
this pull request
Feb 21, 2017
vicb
pushed a commit
that referenced
this pull request
Feb 21, 2017
vicb
added a commit
to vicb/angular
that referenced
this pull request
Mar 15, 2017
chuckjaz
pushed a commit
that referenced
this pull request
Mar 15, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(interfaces): Make ResponseOptionsArgs an interface
As per the Typescript Language Spec having it as an interface means extends, and implements keywords cannot be used. It is unclear why this was declared as a type in the first place
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Is a type definition
What is the new behavior?
Is an interface. Allowing for extends, implements etc.
Does this PR introduce a breaking change? (check one with "x")