Skip to content

fix(interfaces): Make ResponseOptionsArgs an interface #13708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

jacobwindsor
Copy link

fix(interfaces): Make ResponseOptionsArgs an interface

As per the Typescript Language Spec having it as an interface means extends, and implements keywords cannot be used. It is unclear why this was declared as a type in the first place

What kind of change does this PR introduce? (check one with "x")

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Is a type definition

What is the new behavior?
Is an interface. Allowing for extends, implements etc.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X ] No

fix(interfaces): Make ResponseOptionsArgs an interface

As per the [Typescript Language Spec](https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#3.10) having it as an interface means extends, and implements keywords cannot be used. It is unclear why this was declared as a type in the first place
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Feb 10, 2017
@mhevery
Copy link
Contributor

mhevery commented Feb 13, 2017

Please fix PR to pass the CI.

@vicb vicb removed the action: merge The PR is ready for merge by the caretaker label Feb 21, 2017
@vicb
Copy link
Contributor

vicb commented Feb 21, 2017

need to update the public API

vicb pushed a commit to vicb/angular that referenced this pull request Feb 21, 2017
vicb pushed a commit that referenced this pull request Feb 21, 2017
@vicb vicb closed this in fbe4b76 Feb 21, 2017
vicb added a commit to vicb/angular that referenced this pull request Mar 15, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants