Skip to content

feat(compiler): integrate compiler with view engine - main integratio… …n tests work #14284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat(compiler): integrate compiler with view engine - main integratio… …n tests work #14284

wants to merge 1 commit into from

Conversation

tbosch
Copy link
Contributor

@tbosch tbosch commented Feb 3, 2017

First commit is from #14237

@tbosch tbosch requested a review from vicb February 3, 2017 16:15
@tbosch tbosch changed the title feat(compiler): integrate compiler with view engine - hello world wip - feat(compiler): integrate compiler with view engine - hello world Feb 7, 2017
@tbosch tbosch changed the title wip - feat(compiler): integrate compiler with view engine - hello world feat(compiler): integrate compiler with view engine - main integratio… …n tests work Feb 9, 2017
@tbosch tbosch added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Feb 9, 2017
@tbosch tbosch force-pushed the view_compiler branch 2 times, most recently from 38caaaa to 6ffd12c Compare February 9, 2017 23:01
tbosch
tbosch commented Feb 9, 2017
View reviewed changes
modules/@angular/core/src/application_module.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add , at end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

tbosch
tbosch commented Feb 9, 2017
View reviewed changes
modules/@angular/compiler/src/provider_analyzer.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make a var again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

tbosch
tbosch commented Feb 9, 2017
View reviewed changes
modules/@angular/compiler/src/template_parser/template_ast.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment: Only needs to be unique compared to all queries of children of an element.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

tbosch
tbosch commented Feb 9, 2017
View reviewed changes
modules/@angular/core/src/view/provider.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@chuckjaz chuckjaz removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 10, 2017
@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label Feb 10, 2017
@mhevery mhevery closed this in baa654a Feb 10, 2017
@tbosch tbosch deleted the view_compiler branch February 15, 2017 15:49
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@tbosch
feat(compiler): integrate compiler with view engine - main integratio…
52e92d0 
…n tests work (angular#14284)

Part of angular#14013

PR Close angular#14284
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@tbosch @juleskremer
feat(compiler): integrate compiler with view engine - main integratio…
a61a22a 
…n tests work (angular#14284)

Part of angular#14013

PR Close angular#14284
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
3 more reviewers

@mhevery mhevery mhevery approved these changes

@vicb vicb vicb approved these changes

@chuckjaz chuckjaz chuckjaz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tbosch @mhevery @vicb @chuckjaz @googlebot