feat(compiler): integrate compiler with view engine - main integratio… …n tests work #14284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbosch
changed the title
tbosch
changed the title
tbosch
added
action: review
tbosch
force-pushed
the
view_compiler
branch
2 times, most recently
from
38caaaa
to
6ffd12c
Compare
tbosch
commented
Feb 9, 2017
| provide: LOCALE_ID, | ||
| useFactory: _localeFactory, | ||
| deps: [[new Inject(LOCALE_ID), new Optional(), new SkipSelf()]] | ||
| }, | ||
| {provide: APP_INITIALIZER, useValue: _initViewEngine, multi: true} |
tbosch
commented
Feb 9, 2017
|
|
||
| constructor( | ||
| public viewContext: ProviderViewContext, private _parent: ProviderElementContext, | ||
| private _isViewRoot: boolean, private _directiveAsts: DirectiveAst[], attrs: AttrAst[], | ||
| refs: ReferenceAst[], private _sourceSpan: ParseSourceSpan) { | ||
| private _refs: ReferenceAst[], private _sourceSpan: ParseSourceSpan) { |
tbosch
commented
Feb 9, 2017
| @@ -241,6 +241,17 @@ export enum PropertyBindingType { | |||
| Animation | |||
| } | |||
|
|
|||
| export interface QueryId { | |||
There was a problem hiding this comment.
Add comment: Only needs to be unique compared to all queries of children of an element.
tbosch
commented
Feb 9, 2017
| @@ -70,7 +70,7 @@ export function _providerDef( | |||
| outputDefs.push({propName, eventName: outputs[propName]}); | |||
| } | |||
| } | |||
| const depDefs: DepDef[] = deps.map(value => { | |||
| let depDefs: DepDef[] = deps.map(value => { | |||
vicb
approved these changes
Feb 10, 2017
…n tests work Part of angular#14013
tbosch
force-pushed
the
view_compiler
branch
from
6ffd12c
to
29b27d7
Compare
chuckjaz
removed
the
action: review
chuckjaz
approved these changes
Feb 10, 2017
mhevery
approved these changes
Feb 10, 2017
mhevery
pushed a commit
to mhevery/angular
that referenced
this pull request
Feb 10, 2017
…n tests work (angular#14284) Part of angular#14013 PR Close angular#14284
mhevery
pushed a commit
to mhevery/angular
that referenced
this pull request
Feb 10, 2017
…n tests work (angular#14284) Part of angular#14013 PR Close angular#14284
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…n tests work (angular#14284) Part of angular#14013 PR Close angular#14284
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…n tests work (angular#14284) Part of angular#14013 PR Close angular#14284
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is from #14237