Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Remove ChangeDetectorRef Paramter from KeyValueDifferFactory and IterableDifferFactory #14311

Merged
merged 9 commits into from
Feb 9, 2017

Conversation

FrozenPandaz
Copy link
Contributor

@FrozenPandaz FrozenPandaz commented Feb 5, 2017

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

#13961: DifferFactories required a ChangeDetectorRef to be passed into it's create method but did not use it.

What is the new behavior?

The ChangeDetectorRef parameter has been removed from the create method and it's arguments have been removed from places that use it.

Does this PR introduce a breaking change? (check one with "x")

[x] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Applications that have used the Iterable factory will

Other information:

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@FrozenPandaz FrozenPandaz changed the title feat(core): Remove ChangeDetectorRef Paramter from KeyValueDifferFactory and IterableDifferFactory<body> <BLANK LINE> <footer> feat(core): Remove ChangeDetectorRef Paramter from KeyValueDifferFactory and IterableDifferFactory Feb 5, 2017
@FrozenPandaz
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Feb 5, 2017
@FrozenPandaz
Copy link
Contributor Author

I attempted to preserve existing functionality but it was tricky and I am not sure if that is the correct way to overload the first paramter.

@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Feb 9, 2017
@DzmitryShylovich
Copy link
Contributor

@mhevery btw why did this pr pass CI if commit messages don't follow the guidelines?

@mhevery
Copy link
Contributor

mhevery commented Feb 9, 2017 via email

@mhevery mhevery merged commit 45cc444 into angular:master Feb 9, 2017
@FrozenPandaz FrozenPandaz deleted the optional-cdref branch February 9, 2017 23:42
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
…ry and IterableDifferFactory (angular#14311)


BREAKING CHANGE:

- `KeyValueDifferFactory` and `IterableDifferFactory` no longer have `ChangeDetectorRef` as 
  a parameter. It was not used and has been there for historical reasons. If you call 
  `DifferFactory.create(...)` remove the `ChangeDetectorRef` argument.
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
…ry and IterableDifferFactory (angular#14311)


BREAKING CHANGE:

- `KeyValueDifferFactory` and `IterableDifferFactory` no longer have `ChangeDetectorRef` as 
  a parameter. It was not used and has been there for historical reasons. If you call 
  `DifferFactory.create(...)` remove the `ChangeDetectorRef` argument.
ADjenkov added a commit to NativeScript/nativescript-angular that referenced this pull request Nov 2, 2017
sis0k0 pushed a commit to NativeScript/nativescript-angular that referenced this pull request Nov 3, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants