Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always include the NoopAnimationsModule in ServerModule #14784

Closed
vikerman opened this issue Feb 27, 2017 · 7 comments
Closed

Always include the NoopAnimationsModule in ServerModule #14784

vikerman opened this issue Feb 27, 2017 · 7 comments
Assignees
@vikerman
Labels
area: server Issues related to server-side rendering type: bug/fix

Comments

@vikerman
Copy link
Contributor

vikerman commented Feb 27, 2017 •
edited
Loading

This will let animations work as a no-op on the server side when the AnimationModule included in the client app module.
@vikerman vikerman added the area: server Issues related to server-side rendering label Feb 27, 2017
@vikerman vikerman self-assigned this Feb 27, 2017
@IgorMinar IgorMinar added this to the 4.0.0 milestone Feb 28, 2017
@kukjevov
Copy link
Contributor

NoopAnimationsModule included in server side results in error see #15098 :)

@vikerman vikerman mentioned this issue Mar 14, 2017
Closed
3 tasks
@IgorMinar IgorMinar modified the milestones: 4.0.0-blockers, 4.0.0-candidates Mar 14, 2017
@vikerman
Copy link
Contributor Author

Dupe of #15098

@vikerman vikerman removed this from the 4.0.0-blocker-candidates milestone Mar 15, 2017
mhevery pushed a commit that referenced this issue Mar 17, 2017
@vikerman @mhevery
fix(platform-server): setup NoopAnimationsModule in ServerModule by d…
5c5c2ae 
…efault (#15131)

This is so that server side rendering does not throw an exception when it encounters animations on the server side and does not need the user to explicitly setup NoopAnimationsModule in their app server module.

Fixes #15098, #14784.

PR Close #15131
SamVerschueren pushed a commit to SamVerschueren/angular that referenced this issue Mar 18, 2017
@vikerman @SamVerschueren
fix(platform-server): setup NoopAnimationsModule in ServerModule by d…
6b5f2f4 
…efault (angular#15131)

This is so that server side rendering does not throw an exception when it encounters animations on the server side and does not need the user to explicitly setup NoopAnimationsModule in their app server module.

Fixes angular#15098, angular#14784.

PR Close angular#15131
@ysus
Copy link

ysus commented Apr 21, 2017

@kukjevov can you fix the problem?

@kukjevov
Copy link
Contributor

It was already fixed

asnowwolf pushed a commit to asnowwolf/angular that referenced this issue Aug 11, 2017
@vikerman
fix(platform-server): setup NoopAnimationsModule in ServerModule by d…
e2b591f 
…efault (angular#15131)

This is so that server side rendering does not throw an exception when it encounters animations on the server side and does not need the user to explicitly setup NoopAnimationsModule in their app server module.

Fixes angular#15098, angular#14784.

PR Close angular#15131
juleskremer pushed a commit to juleskremer/angular that referenced this issue Aug 28, 2017
@vikerman @juleskremer
fix(platform-server): setup NoopAnimationsModule in ServerModule by d…
e8780cd 
…efault (angular#15131)

This is so that server side rendering does not throw an exception when it encounters animations on the server side and does not need the user to explicitly setup NoopAnimationsModule in their app server module.

Fixes angular#15098, angular#14784.

PR Close angular#15131
@CaerusKaru CaerusKaru mentioned this issue Sep 17, 2017
Closed
@diestrin
Copy link
Contributor

diestrin commented Oct 4, 2017

@kukjevov what version was it fixed? I'm using 4.1.3 and it still throws an error.
cc: @TheloniousSF

@kukjevov
Copy link
Contributor

Sorry for late answer, but i think it was fixed in one of 4.0.x releases. Not sure thou.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vikerman vikerman

Labels
area: server Issues related to server-side rendering type: bug/fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@vikerman @IgorMinar @diestrin @ysus @kukjevov