-
Notifications
You must be signed in to change notification settings - Fork 25.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runGuardsAndResolvers: 'paramsOrQueryParamsChange': resolve on query param change works but data does not seems to be passed to subscribed Observable. #15290
Comments
Can you reproduce in a plunkr please |
@Toxicable I'm sorry I'm afraid that I am not really familiar with plunker and fiddling around with it to create an angular4.0.0-rc.5 setup will simply take too much time, that I don't have right now. But I created a sample app with angular-cli and moved it to my github: https://github.com/basilikum/bug15290_ng4 It is very straight forward: the link "change query param" changes the query param |
@basilikum here's a template plunkr for v4 |
@Toxicable Sorry I could not get it to run within plunker. Probably just a small mistake but I have to look into it but currently not time. I can try to get the plunker demo to run within the next 2 days or so but probably not before that. Sorry again. Does the github repo not help? |
I didn't try your github repo but it works fine in this plunkr |
@Toxicable Hmm...but your plunker does not even change the query params in the url? Still does not seem to work for me in this example: http://plnkr.co/edit/UC39EjWv261lnbGMxVqT?p=preview |
@basilikum Right, sorry I see what you're saying. Okay well i'm not sure what's up in this case then |
@Toxicable Ok, thank you anyway. Especially for the help with plunker. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I'm submitting a ...
Current behavior
When using
runGuardsAndResolvers: 'paramsOrQueryParamsChange'
to make sure that a resolver is run whenever a query parameter changes, the resolver does runs, but the fetched data is not passed onto the subscription to theroute.data
Observable within the component.Expected behavior
If I subscribe to
route.data
within the component, I would expect to get updates whenever new data is fetched, but I only get the initial data, no updates.Please tell us about your environment:
Ubuntu 16.04
Angular version: 2.0.X
Angular 4.0.0-rc.5
Browser:
Chrome 54
The text was updated successfully, but these errors were encountered: