Skip to content

Conversation

sis0k0
Copy link
Contributor

@sis0k0 sis0k0 commented Mar 20, 2017

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@sis0k0
Copy link
Contributor Author

sis0k0 commented Mar 20, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

sis0k0 added a commit to NativeScript/nativescript-angular that referenced this pull request Mar 20, 2017
sis0k0 added a commit to NativeScript/nativescript-angular that referenced this pull request Mar 20, 2017
@DzmitryShylovich
Copy link
Contributor

@jasonaden can you take a look please?

@jasonaden
Copy link
Contributor

LGTM

@jasonaden jasonaden added this to the 4.0.0-blockers milestone Mar 20, 2017
@jasonaden jasonaden added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project labels Mar 20, 2017
@mhevery mhevery closed this in 2489e4b Mar 21, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants