revert: build(aio): implement prerendering #15346
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added
comp: aio
action: review
|
The angular.io preview for fce62ee is available here. |
|
git conflicts :-| |
IgorMinar
added
action: cleanup
gkalpak
force-pushed
the
build-aio-remove-prerendering
branch
from
fce62ee to
e6f1fd6
Compare
|
The angular.io preview for e6f1fd6 is available here. |
IgorMinar
approved these changes
Mar 21, 2017
This reverts commit d0bc83c. Protractor-based prerendering is flakey on Travis and takes several minutes to complete, slowing down the build. Prerendering has a lower impact now that we use a ServiceWorker. We will revisit in the future (probably using a `PlatformServer`-based approach).
gkalpak
force-pushed
the
build-aio-remove-prerendering
branch
from
e6f1fd6 to
48a2ee0
Compare
mhevery
approved these changes
Mar 22, 2017
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
This reverts commit d0bc83c. Protractor-based prerendering is flakey on Travis and takes several minutes to complete, slowing down the build. Prerendering has a lower impact now that we use a ServiceWorker. We will revisit in the future (probably using a `PlatformServer`-based approach). PR Close angular#15346
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
This reverts commit d0bc83c. Protractor-based prerendering is flakey on Travis and takes several minutes to complete, slowing down the build. Prerendering has a lower impact now that we use a ServiceWorker. We will revisit in the future (probably using a `PlatformServer`-based approach). PR Close angular#15346
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d0bc83c.
Protractor-based prerendering is flakey on Travis and takes several minutes to
complete, slowing down the build. Prerendering has a lower impact now that we
use a ServiceWorker. We will revisit in the future (probably using a
PlatformServer-based approach).