fix(upgrade): component injectors should not link the module injector… #15385
Conversation
vicb
force-pushed
the
0322-upInjTake2
branch
3 times, most recently
from
7cd099c to
cb11def
Compare
There was a problem hiding this comment.
Nit: No need for <ng-content> (afaict). You can just have 'ng2' (or an empty template if you don't care about it).
There was a problem hiding this comment.
right, I tried many things before coming to this test... will remove
There was a problem hiding this comment.
Nit: No need for this directive. You can use const element = html('<ng2></ng2>') below instead.
There was a problem hiding this comment.
Nit: You could probably use the bootstrap helper (and save two whole lines of code 😛):
bootstrap(platformBrowserDynamic(), Ng2Module, element, ng1Module).then(upgrade => {
const modInjector = upgrade.injector;
// Emulate the router lazy loading ...
...
});
There was a problem hiding this comment.
Add a . before in such case
There was a problem hiding this comment.
childMod.componentFactoryResolver
There was a problem hiding this comment.
Nit: components= --> components
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.